Add preference in toolbar #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I didn't realize you'd be working on this so soon! Can you do me a favor and hold back on other changes (except for the small CSS changes I just suggested)? I'm currently in the process of doing some cleaning up--including redoing the file structure and adding ESLint. This has some ES5 syntax which is totally fine, because I haven't been writing 100% perfect ES6, but I need to go through and fix some of this stuff. |
|
|
||
| .preference__title { | ||
| margin: 0 0; | ||
| font-size: #{$base-font-size}px; |
There was a problem hiding this comment.
this font size should be in rem's
|
I'm just going to make these css changes myself, so that I can get started on file restructure. |
|
My bad, I just saw this! Sure, I'll hold back on the rest. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Below are the current changes included to add preferences
